gh-128074: Support +HH format as time zone for strptime#130390
Open
donbarbos wants to merge 14 commits intopython:mainfrom
Open
gh-128074: Support +HH format as time zone for strptime#130390donbarbos wants to merge 14 commits intopython:mainfrom
+HH format as time zone for strptime#130390donbarbos wants to merge 14 commits intopython:mainfrom
Conversation
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
This has conflicts now.
Contributor
Author
|
After adding the |
donbarbos
changed the title
+HH format as time zone in datetime.strptime+HH format as time zone for strptime
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Please fix the conflicts.
Member
There was a problem hiding this comment.
This has side effects, e.g. on main:
>>> datetime.strptime("+1020", "%z%M")
Traceback (most recent call last):
File "<python-input-2>", line 1, in <module>
datetime.strptime("+1020", "%z%M")
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
File "/home/stan/dev/cpython/Lib/_strptime.py", line 830, in _strptime_datetime_datetime
tt, fraction, gmtoff_fraction = _strptime(data_string, format)
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
File "/home/stan/dev/cpython/Lib/_strptime.py", line 560, in _strptime
raise ValueError("time data %r does not match format %r" %
(data_string, format))
ValueError: time data '+1020' does not match format '%z%M'
Whereas the PR:
>>> from datetime import datetime
>>> datetime.strptime("+1020", "%z%M")
datetime.datetime(1900, 1, 1, 0, 20, tzinfo=datetime.timezone(datetime.timedelta(seconds=36000)))
We need to consider this carefully, although this is probably just a theoretical issue, I doubt it appears in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the minute (
MM) part optional for time zone.New behavior:
Old behavior:
📚 Documentation preview 📚: https://cpython-previews--130390.org.readthedocs.build/en/130390/library/datetime.html